docs: add Copilot code-review instructions#16
Merged
Conversation
> 🤖 Generated by the Daily AI Assistant
14 tasks
There was a problem hiding this comment.
Pull request overview
Adds a repository-specific .github/copilot-instructions.md so GitHub Copilot code review runs with devantler-tech/plugins-tailored guidance (instead of relying on AGENTS.md, which Copilot review does not read).
Changes:
- Add concise Copilot code-review checklist covering manifest parity, plugin/skill layout, and CI/security expectations.
- Document repo contract points (two-manifest parity, upstream-managed skills, least-privilege workflows) for consistent reviews.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ions Address Copilot review threads on #16: - Pin *every* external action (repo SHA-pins all uses:, incl. actions/*), not just third-party - Permissions: reflect that update-agent-skills legitimately needs top-level write - Qualify .github/instructions/ as 'if present'; make the closing line self-contained Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![botantler[bot]](https://avatars.githubusercontent.com/in/1025824?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
.github/copilot-instructions.md(3449 chars, ≤4000) todevantler-tech/plugins— the fileGitHub Copilot code review actually reads (it reads
.github/copilot-instructions.md+.github/instructions/**/*.instructions.md, notAGENTS.md). Continues the portfolio-widerollout tracked in monorepo#1771.
Why
pluginsis a public shared library consumed across every agent install, but it had noreview-instructions file — so Copilot's review ran without any repo-specific guidance. This is a
concise, review-focused checklist (short imperative rules, not an
AGENTS.mddump), tailored tothis repo's actual contract:
.github/plugin/marketplace.jsonand.claude-plugin/marketplace.jsonmust stay byte-for-byte in parity (CI diffs them); any plugin-setchange edits both + the README in lockstep;
sourcestays a relative path; wording staystool-neutral.
SKILL.mdfiles aregh skill install-ed andvalidate against the agentskills.io spec; never hand-edit one to diverge (fix it in
devantler-tech/skills).plugins/<plugin>/plugin.json(kebab-case name,"skills": "skills/") withskills at depth 4.
# v<version>comment,permissions: {}+least privilege per job,
persist-credentials: false,actionlint-clean.The closing line mirrors the monorepo exemplar (Copilot reads this file at ≤4000 chars, doesn't read
AGENTS.md, defer toAGENTS.mdwhen unsure).Validation
Markdown-only, no code paths touched — the repo's CI (
CI - Required Checks: validate-manifests +discover-skills + validate-spec) is unaffected by adding a docs file. Content tailored from the
repo's own
AGENTS.mdconventions and verified against the liveci.yaml(required check name,manifest-parity gate, agentskills.io spec matrix).
Drafted for maintainer promotion. On promotion, drive to merge per the standard own-PR path.